From 9bb2c999d6b7eb574c23209a2ec543abad891f7f Mon Sep 17 00:00:00 2001 From: Peter Hawkins Date: Tue, 11 Oct 2022 18:59:07 -0700 Subject: [PATCH] Reenable some tests disabled in the past because of an LLVM bug. The issue no longer reproduces at head. PiperOrigin-RevId: 480505525 --- tests/lax_autodiff_test.py | 6 ------ tests/lax_scipy_test.py | 4 ---- 2 files changed, 10 deletions(-) diff --git a/tests/lax_autodiff_test.py b/tests/lax_autodiff_test.py index 92384f00c00c..a6ad232fcb7f 100644 --- a/tests/lax_autodiff_test.py +++ b/tests/lax_autodiff_test.py @@ -367,12 +367,6 @@ def testConvGeneralDilatedGrad(self, lhs_shape, rhs_shape, dtype, strides, if dtype == np.float16: raise SkipTest("float16 numerical issues") # TODO(mattjj): resolve - if (jtu.device_under_test() == "cpu" and dtype == np.float64 and - lhs_shape == (1,1,6,7) and rhs_shape == (2,1,1,2) and strides == (2, 1) - and padding == ((0, -1), (0, 0)) and lhs_dil == (1, 1) and - rhs_dil == (1, 1)): - # TODO(b/173608403): reenable after LLVM fix. - raise SkipTest("Skipping test due to LLVM lowering bug") rng = jtu.rand_default(self.rng()) tol = {dtypes.bfloat16: 1e-0, np.float16: 5e-1, np.float32: 1e-3} diff --git a/tests/lax_scipy_test.py b/tests/lax_scipy_test.py index 2cb600eeddcc..9ecc79348824 100644 --- a/tests/lax_scipy_test.py +++ b/tests/lax_scipy_test.py @@ -252,10 +252,6 @@ def testLogSumExpNans(self): @jax.numpy_dtype_promotion('standard') # This test explicitly exercises dtype promotion def testScipySpecialFun(self, scipy_op, lax_op, rng_factory, shapes, dtypes, test_autodiff, nondiff_argnums): - if (jtu.device_under_test() == "cpu" and - (lax_op is lsp_special.gammainc or lax_op is lsp_special.gammaincc)): - # TODO(b/173608403): re-enable test when LLVM bug is fixed. - raise unittest.SkipTest("Skipping test due to LLVM lowering bug") rng = rng_factory(self.rng()) args_maker = self._GetArgsMaker(rng, shapes, dtypes) args = args_maker()