This repository has been archived by the owner on Oct 2, 2020. It is now read-only.
Remove unused styles in legacy css. For #126 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,7 @@ function SponsorGroup({sponsors, title}) { | |||
| { | |||
| chunkedSponsors.map((rowSponsors, index) => { | |||
| return ( | |||
| <div className={`${css(styles.group)} +space-children`} key={index}> | |||
| <div className={css(styles.group)} key={index}> | |||
There was a problem hiding this comment.
are you sure nothing changes by removing this class? I would expect the sponsors get closer together. Could you please provide a screenshot? Thanks!
There was a problem hiding this comment.
Yeah the class isn't doing anything here for some reason.
With class:
Class removed:
With class on mobile:
Class removed on mobile:
|
Thanks for working on this! |
|
No worries at all! And my apologies, on the episodes page the +space-children class was actually adding a little spacing between the person notes and image, hence why I added it back to the css file and to that page. My bad I missed it earlier |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unused styles removed from legacy.css (all the other styles except these two are being used at least once).
Migrating to aphrodite shouldn't be too difficult. In all of the pages where the styles appear, the .container class is enclosing and there's not many styles to reference. Just need to replicate the styles in-line for each of the pages then we can remove legacy.css 👍