Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer direct buffers when creating ByteBuffer instances #73

Open
javagl opened this issue Aug 8, 2022 · 0 comments
Open

Prefer direct buffers when creating ByteBuffer instances #73

javagl opened this issue Aug 8, 2022 · 0 comments

Comments

@javagl
Copy link
Owner

javagl commented Aug 8, 2022

Brought up in #60 :

There are some places where a ByteBuffer is created that is not a direct ByteBuffer. In order to improve interoperability with native libraries that require direct buffers, buffers created by JglTF should preferably be direct buffers.

This will require some potentially breaking changes, for example, related to the IO#read methods. But it might be possible to keep these functions, mark them as deprecated, and remove them soon, because clients should usually not call the low-level IO methods anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant