Unsafe increment of static field

[sebbASF]

Mutable static fields should be synchronised to ensure safe publication.
There is no guarantee that the following code will generate unique names:

jna/contrib/platform/src/com/sun/jna/platform/win32/User32Util.java

Lines 166 to 170 in 6706361

	private static long messageLoopId = 0;
	public MessageLoopThread() {
	setName("JNA User32 MessageLoop " + (++messageLoopId));
	}

The messageLoopId variable should probably be replaced by an AtomicLong.

[sebbASF]

Same issue here:

jna/contrib/platform/src/com/sun/jna/platform/win32/W32FileMonitor.java

Line 167 in 6706361

private static int watcherThreadID;

Also, this is an int, whereas the other is a long, but both are used for thread ids. Is it certain that an int is sufficient here?

[matthiasblaesing]

I don't see a real problem. These are the names of the threads, so it might not look nice in the end, but will also not cause harm. What is more, if you really spawn threads at a rate where this becomes problematic, you have other problems.