-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JNA no longer buildable with a target JDK of 1.6 #1025
Comments
Good catch - the build produces bytecode that is compatible with a 1.6 VM, but the classpath is more problematic. We can't build against a JDK < 8 because for support for JDK >= 9 we need annotations introduced with JDK 8. For the concrete problem, I agree with your solution. |
Looks great to me! I'm not very familiar with animal-sniffer, but looks like it can't be worse than nothing. |
Thanks for checking. I merged the changeset to master and will give it a few days to settle. I want to see if other problems crop up and if not, I'll cut a release from that. |
Hi,
Commit 267bbce calls the parameterCount method, which has been marked as >= 1.8.
Looks like this is easily patched via m.getParameterTypes().length, but the whole VARIANT is full of magic so I'm afraid of breaking something here.
Cheers,
Will
The text was updated successfully, but these errors were encountered: