From de7dd2e82cd72745b367174232cac454e262eeae Mon Sep 17 00:00:00 2001
From: Carlos Ballesteros <soywiz@gmail.com>
Date: Fri, 2 Dec 2022 09:22:18 +0100
Subject: [PATCH] Adds support for a custom SymbolProvider in NativeLibrary &
 Library

---
 CHANGES.md                          |  1 +
 src/com/sun/jna/Library.java        |  5 +++
 src/com/sun/jna/NativeLibrary.java  | 18 ++++++++-
 src/com/sun/jna/SymbolProvider.java | 43 ++++++++++++++++++++++
 test/com/sun/jna/DirectTest.java    | 57 +++++++++++++++++++++++++++++
 5 files changed, 122 insertions(+), 2 deletions(-)
 create mode 100644 src/com/sun/jna/SymbolProvider.java

diff --git a/CHANGES.md b/CHANGES.md
index 0ba882e459..27f50204a4 100644
--- a/CHANGES.md
+++ b/CHANGES.md
@@ -12,6 +12,7 @@ Features
 * [#1471](https://github.com/java-native-access/jna/pull/1471): Add `c.s.j.p.win32.Advapi32Util#isCurrentProcessElevated` and associated Types - [@dbwiddis](https://github.com/dbwiddis).
 * [#1474](https://github.com/java-native-access/jna/pull/1474): Add `c.s.j.p.win32.WbemCli#IWbemClassObject.IWbemQualifierSet`, `IWbemServices.GetObject`, `IWbemContext.SetValue` and associated methods - [@rchateauneu](https://github.com/rchateauneu).
 * [#1482](https://github.com/java-native-access/jna/pull/1482): Add multilingual support of `Kernel32Util.formatMessage` - [@overpathz](https://github.com/overpathz).
+* [#1490](https://github.com/java-native-access/jna/pull/1490): Adds support for a custom `SymbolProvider` in `NativeLibrary` & `Library` - [@soywiz](https://github.com/soywiz).
 
 Bug Fixes
 ---------
diff --git a/src/com/sun/jna/Library.java b/src/com/sun/jna/Library.java
index ce7dcbc8d3..3b79fabde0 100644
--- a/src/com/sun/jna/Library.java
+++ b/src/com/sun/jna/Library.java
@@ -114,6 +114,11 @@ public interface Library {
      */
     String OPTION_CLASSLOADER = "classloader";
 
+    /**
+     * Supports a custom symbol provider for the NativeLibrary (see {@link SymbolProvider})
+     */
+    String OPTION_SYMBOL_PROVIDER = "symbol-provider";
+
     static class Handler implements InvocationHandler {
 
         static final Method OBJECT_TOSTRING;
diff --git a/src/com/sun/jna/NativeLibrary.java b/src/com/sun/jna/NativeLibrary.java
index d7bd902110..27eb569423 100644
--- a/src/com/sun/jna/NativeLibrary.java
+++ b/src/com/sun/jna/NativeLibrary.java
@@ -87,13 +87,20 @@
 public class NativeLibrary implements Closeable {
 
     private static final Logger LOG = Logger.getLogger(NativeLibrary.class.getName());
-    private final static Level DEBUG_LOAD_LEVEL = DEBUG_LOAD ? Level.INFO : Level.FINE;
+    private static final Level DEBUG_LOAD_LEVEL = DEBUG_LOAD ? Level.INFO : Level.FINE;
+    private static final SymbolProvider NATIVE_SYMBOL_PROVIDER = new SymbolProvider() {
+        @Override
+        public long getSymbolAddress(long handle, String name, SymbolProvider parent) {
+            return Native.findSymbol(handle, name);
+        }
+    };
 
     private Cleaner.Cleanable cleanable;
     private long handle;
     private final String libraryName;
     private final String libraryPath;
     private final Map<String, Function> functions = new HashMap<String, Function>();
+    private final SymbolProvider symbolProvider;
     final int callFlags;
     private String encoding;
     final Map<String, ?> options;
@@ -123,6 +130,13 @@ private NativeLibrary(String libraryName, String libraryPath, long handle, Map<S
         this.callFlags = callingConvention;
         this.options = options;
         this.encoding = (String)options.get(Library.OPTION_STRING_ENCODING);
+        SymbolProvider optionSymbolProvider = (SymbolProvider)options.get(Library.OPTION_SYMBOL_PROVIDER);
+        if (optionSymbolProvider == null) {
+            this.symbolProvider = NATIVE_SYMBOL_PROVIDER;
+        } else {
+            this.symbolProvider = optionSymbolProvider;
+        }
+
         if (this.encoding == null) {
             this.encoding = Native.getDefaultStringEncoding();
         }
@@ -636,7 +650,7 @@ long getSymbolAddress(String name) {
         if (handle == 0) {
             throw new UnsatisfiedLinkError("Library has been unloaded");
         }
-        return Native.findSymbol(handle, name);
+        return this.symbolProvider.getSymbolAddress(handle, name, NATIVE_SYMBOL_PROVIDER);
     }
 
     @Override
diff --git a/src/com/sun/jna/SymbolProvider.java b/src/com/sun/jna/SymbolProvider.java
new file mode 100644
index 0000000000..5dd21aafeb
--- /dev/null
+++ b/src/com/sun/jna/SymbolProvider.java
@@ -0,0 +1,43 @@
+/* Copyright (c) 2022 Carlos Ballesteros, All Rights Reserved
+ *
+ * The contents of this file is dual-licensed under 2
+ * alternative Open Source/Free licenses: LGPL 2.1 or later and
+ * Apache License 2.0. (starting with JNA version 4.0.0).
+ *
+ * You can freely decide which license you want to apply to
+ * the project.
+ *
+ * You may obtain a copy of the LGPL License at:
+ *
+ * http://www.gnu.org/licenses/licenses.html
+ *
+ * A copy is also included in the downloadable source code package
+ * containing JNA, in file "LGPL2.1".
+ *
+ * You may obtain a copy of the Apache License at:
+ *
+ * http://www.apache.org/licenses/
+ *
+ * A copy is also included in the downloadable source code package
+ * containing JNA, in file "AL2.0".
+ */
+package com.sun.jna;
+
+/**
+ * Interface to define a custom symbol provider.
+ *
+ * This can be used for method hooking, or special
+ * classes like direct mapping the Win32 OpenGL.
+ */
+public interface SymbolProvider {
+    /**
+     * Gets the address of a symbol by its name and the handle of the library.
+     *
+     * @param handle Handle of the original library
+     * @param name Name of the symbol to load
+     * @param parent Parent symbol provider
+     *
+     * @return Address of the symbol, typically a function.
+     */
+    long getSymbolAddress(long handle, String name, SymbolProvider parent);
+}
diff --git a/test/com/sun/jna/DirectTest.java b/test/com/sun/jna/DirectTest.java
index 3e2f4b563f..1c15e16889 100644
--- a/test/com/sun/jna/DirectTest.java
+++ b/test/com/sun/jna/DirectTest.java
@@ -44,6 +44,7 @@ public static void main(java.lang.String[] argList) {
 
     static class MathLibrary {
 
+        public static native double sin(double x);
         public static native double cos(double x);
 
         static {
@@ -51,6 +52,52 @@ static class MathLibrary {
         }
     }
 
+    static class MathLibraryWithSymbolProvider {
+
+        public static native double sin(double x);
+        public static native double cos(double x);
+
+        static {
+            Native.register(MathLibraryWithSymbolProvider.class, NativeLibrary.getInstance(Platform.MATH_LIBRARY_NAME, Collections.singletonMap(
+                    Library.OPTION_SYMBOL_PROVIDER,
+                    new SymbolProvider() {
+                        @Override
+                        public long getSymbolAddress(long handle, String name, SymbolProvider parent) {
+                            if (name.equals("sin")) {
+                                return parent.getSymbolAddress(handle, "cos", null);
+                            } else {
+                                return parent.getSymbolAddress(handle, "sin", null);
+                            }
+                        }
+                    }
+            )));
+        }
+    }
+
+    interface MathInterfaceWithSymbolProvider extends Library {
+
+        double sin(double x);
+        double cos(double x);
+
+        MathInterfaceWithSymbolProvider INSTANCE = Native.load(
+                Platform.MATH_LIBRARY_NAME,
+                MathInterfaceWithSymbolProvider.class, Collections.singletonMap(
+                        Library.OPTION_SYMBOL_PROVIDER,
+                        new SymbolProvider() {
+                            @Override
+                            public long getSymbolAddress(long handle, String name, SymbolProvider parent) {
+                                if (name.equals("sin")) {
+                                    return parent.getSymbolAddress(handle, "cos", null);
+                                } else {
+                                    return parent.getSymbolAddress(handle, "sin", null);
+                                }
+                            }
+                        }
+                )
+        );
+    }
+
+
     interface MathInterface extends Library {
         double cos(double x);
     }
@@ -299,6 +346,16 @@ public String getFunctionName(NativeLibrary lib, Method method) {
         }
     }
 
+    public void testDirectMappingSymbolProvider() {
+        assertEquals(MathLibrary.cos(0.0), MathLibraryWithSymbolProvider.sin(0.0));
+        assertEquals(MathLibrary.sin(0.0), MathLibraryWithSymbolProvider.cos(0.0));
+    }
+
+    public void testInterfaceMappingSymbolProvider() {
+        assertEquals(MathLibrary.cos(0.0), MathInterfaceWithSymbolProvider.INSTANCE.sin(0.0));
+        assertEquals(MathLibrary.sin(0.0), MathInterfaceWithSymbolProvider.INSTANCE.cos(0.0));
+    }
+
     public static class PointerNativeMapped implements NativeMapped {
         String nativeMethodName;
         @Override