$ref loop detection after second call of 'validate' method

[lazdmx]

Hi!

I found that if I try to validate json-instance against a schema by specified path (validator.validate("#/schema/in", json)), validation pass for first time, but second third and so on calls will report an "$ref loop" error. It seems strange since I try to revalidate same json-instance.

[fge]

Can you post your schema and sample data?

[fge]

Any input? I'm at a loss on reproducing this issue. Also, what version are you using? Is this 0.4, master?

[lazdmx]

Ok, for example

Schemas:

{
  "search": {
    "in": {
      "type": "object",
      "properties": {
        "filter": {
          "type": "string",
          "required": true
        },
        "max": {
          "type": "integer",
          "minimum": 1,
          "required": true
        }
      },
      "additionalProperties": false
    },
    "out": {
      "type": "object",
      "properties": {
        "status": {
          "type":"number"
        },
        "subjects":{
          "type": "array",
          "items":{
            "type": "object",
            "properties": {
              "name": {
                "type": "string"
              },
              "passport": {
                "type": "string"
              }
            }
          }
        }
      }
    }
  }
}

Json instance :

{
  "status":0,
  "subjects":[{
    "name": "User",
    "passport": "12345679"
  }]
}

Code:

public class App {

  private static final Logger logger = Logger.getLogger(App.class.getName());

  public static void main(String[] args) {

    try {
      File schemaFile =
              new File(new File(System.getProperty("user.dir")),
              "target/classes/schemas/all.json");
      File jsonFile =
              new File(new File(System.getProperty("user.dir")),
              "target/classes/in.json");
      final JsonNode schemas = JsonLoader.fromFile(schemaFile);
      final JsonNode js = JsonLoader.fromFile(jsonFile);

      final JsonValidator validator = new JsonValidator(schemas);

      for (int i = 0; i < 2; ++i) {
        ValidationReport report = validator.validate("#/search/out", js);
        if (report.isSuccess()) {
          logger.info("Success");
        } else {
          logger.info("Error:");
          for (String mes : report.getMessages()) {
            logger.info(mes);
          }

        }
      }

    } catch (JsonValidationFailureException ex) {
      logger.log(Level.WARNING, "Validation Failure", ex);
    } catch (IOException ex) {
      logger.log(Level.SEVERE, "Unable to read JSON schemas", ex);
    }
  }
}

[fge]

OK, I can reproduce it, looking it up...

[fge]

43cb1f2 <-- this fixes it. Nice catch!

I prepare for release 0.4.1.

[fge]

OK, 0.4.1 is in the pipe. Let me know when you have downloaded it!

[fge]

I take it that "no news, good news".

[lazdmx]

All seams to be workable now, thanks.