Support fit files from Zwift #12
Closed
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not really sure what I was doing here but it seems to fix my problem. Hopefully this is OK |
|
Updated the PR again as I'm dumb. I made it run and upload zwift files but not actually edit them to another device. That is now fixed |
|
Since there were some pretty big changes to the main branch, I'm going to close this and re-open with a rebased branch. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix the problem with Zwift files for me. This will close #11
The problem seems to simply be that the ID 21 (Event) isn't supported somewhere in the tool chain. So we just skip it completely.
The data stored in the event message looks pretty pointless so I think it's safe to remove. Maybe there is a better way to do this?