Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the peer address for PendingConnection #206

Open
dustin opened this issue Jun 1, 2020 · 1 comment
Open

Provide the peer address for PendingConnection #206

dustin opened this issue Jun 1, 2020 · 1 comment
Labels

Comments

@dustin
Copy link

dustin commented Jun 1, 2020

Currently, a websocket server doesn't have any way to identify the source of incoming connections. The most simple use case is logging the address of incoming connections against a server. One could also process requests differently based on incoming address/network.

I see this used to exist, but was reverted in d1f7eeb without explanation.

@domenkozar
Copy link
Collaborator

It seems to have been reverted because there was no implementation actually get the address.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants