-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matrix invite Link get reported as InvalidUrlException #1050
Comments
(this is probably an upstream bug, but I am unsure where to report upstream) |
It seems like matrix is using non-compliant URIs (matrix-org/matrix.to#17) |
If matrix uses non-compliant URIs, there nothing to do currently. Good news though, Hakyll considers URIs to be strings at first, which are then parsed. If someone was really keen on supporting matrix URIs, then Hakyll could be extended to either:
Personally, I am much more partial to solution 1 (handling matrix URIs in a special case). It seems the least disruptive and the most in-keeping with the spirit of ensuring live links. I am happy to review pull requests. In the meantime, you can skip checking of external uris using the |
Hi @LaurentRDC, Can I please work on this ? |
Of course, go ahead |
I am unsure whether they are valid URIs, but the check fails for links like
https://matrix.to/#/#roomname:matrix.my-cool-server.com
with anInvalidUrlException
.The text was updated successfully, but these errors were encountered: