Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--require fails with runner.addRequires is not a function in 5.x #208

Closed
mattem opened this issue Jun 13, 2023 · 1 comment
Closed

--require fails with runner.addRequires is not a function in 5.x #208

mattem opened this issue Jun 13, 2023 · 1 comment

Comments

@mattem
Copy link

mattem commented Jun 13, 2023

When running with --require (as done in rules_jasmine for Bazel), the error runner.addRequires is not a function is thrown.

It seems this was renamed to addRequires_ here:

jasmine-npm/lib/runner_base.js

Line 337 in d0b93c4

addRequires_(requires) {

But still called via addRequires here:

jasmine-npm/lib/command.js

Line 193 in d0b93c4

runner.addRequires(options.requires);

@sgravrock
Copy link
Member

This is fixed in 5.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattem @sgravrock