specs failing to run exits task with exit code 0

[menzer]

The issue introduced by the jasmine reporters upgrade (#46) is compounded by the fact that that the failure of jasmine.executeSpecsInFolder is caught and simply logged, causing the task to exit with 0 when jasmine fails to run.

Specs failing to run due to the runner crashing should cause a build to fail.

[meertens]

Seems to be a problem with a breaking update of the reporters, passed on from jasmine-node. The issue is discussed in the following place:
mhevery/jasmine-node#333

[menzer]

Yes, that is a separate issue, but the grunt task itself should not report success when it fails to run. That means that when the reporters update broke jasmine-node and tests stopped running and started crashing, the task still exited with a success code and CI servers went on their merry way, oblivious that tests were no longer running. That's not desired behavior.

[meertens]

Ah, true. Sorry for misreading that. The issue you bring up is a problem too indeed.

[tjlahr]

+1

Has anybody picked this issue up?

[theothermattm]

+1 this just bit me hard