-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove underscore-min.js from npm package #1840
Conversation
Related to #190. This is a breaking change and not inline with a 1.7.1 revert. |
remove underscore-min.js from npm package
So is 1.7.1 happening? I'm confused why this non-revert breaking change is allowed through when devs have chimed in saying they depend on it. Wouldn't it make sense to remove this at the 2.0 bump instead? This change is also inconsistent with bower.json and component.json which were changed to include the minified file. |
Here's a simple search of devs using the minified file in the npm package. |
I agree with @jdalton . This change should be reserved for version 2.0. It would be especially bad for the 1.7.1 revert to introduce breaking changes. |
Yep yep, let's try to fix one thing before we break another. 😄 |
Is it time to create a |
I'm into that. Let me back this one out for the moment. |
👍 @akre54! |
Fixes #1839.