Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove underscore-min.js from npm package #1840

Merged
merged 1 commit into from
Sep 9, 2014

Conversation

michaelficarra
Copy link
Collaborator

Fixes #1839.

@jdalton
Copy link
Contributor

jdalton commented Sep 9, 2014

Related to #190. This is a breaking change and not inline with a 1.7.1 revert.

akre54 added a commit that referenced this pull request Sep 9, 2014
remove underscore-min.js from npm package
@akre54 akre54 merged commit 1710113 into jashkenas:master Sep 9, 2014
@jdalton
Copy link
Contributor

jdalton commented Sep 9, 2014

So is 1.7.1 happening? I'm confused why this non-revert breaking change is allowed through when devs have chimed in saying they depend on it. Wouldn't it make sense to remove this at the 2.0 bump instead?

This change is also inconsistent with bower.json and component.json which were changed to include the minified file.

@jdalton
Copy link
Contributor

jdalton commented Sep 9, 2014

Here's a simple search of devs using the minified file in the npm package.

@joshuacc
Copy link

joshuacc commented Sep 9, 2014

I agree with @jdalton . This change should be reserved for version 2.0. It would be especially bad for the 1.7.1 revert to introduce breaking changes.

@braddunbar
Copy link
Collaborator

Yep yep, let's try to fix one thing before we break another. 😄

@davidchambers
Copy link
Contributor

Is it time to create a v2 branch?

@akre54
Copy link
Collaborator

akre54 commented Sep 9, 2014

I'm into that. Let me back this one out for the moment.

@akre54
Copy link
Collaborator

akre54 commented Sep 9, 2014

a8301ea

@joshuacc
Copy link

joshuacc commented Sep 9, 2014

👍 @akre54!

@akre54 akre54 mentioned this pull request Sep 9, 2014
8 tasks
@megawac megawac added this to the v2.0 milestone Sep 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Map file for minified file in npm package
8 participants