Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make _.contains use _.indexOf for array-like collections. #1552

Closed
jdalton opened this issue Apr 4, 2014 · 2 comments · Fixed by #1556
Closed

Make _.contains use _.indexOf for array-like collections. #1552

jdalton opened this issue Apr 4, 2014 · 2 comments · Fixed by #1556

Comments

@jdalton
Copy link
Contributor

jdalton commented Apr 4, 2014

With the recent patch to remove native forks _.contains should fork for array-like objects using _.indexOf.
@jdalton jdalton changed the title Tweak _.contains to take _.indexOf for array-like collections. Tweak _.contains to use _.indexOf for array-like collections. Apr 4, 2014
@jdalton
Copy link
Contributor Author

jdalton commented Apr 6, 2014

/cc @davidchambers can you tackle this?

@jdalton jdalton changed the title Tweak _.contains to use _.indexOf for array-like collections. Make _.contains use _.indexOf for array-like collections. Apr 6, 2014
@davidchambers
Copy link
Contributor

Sure. I'll work on a PR.

@jdalton jdalton mentioned this issue Apr 6, 2014
Closed
@davidchambers davidchambers mentioned this issue Apr 7, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

define _.contains for array-likes in terms of _.indexOf davidchambers/underscore
2 participants
@jdalton @davidchambers