-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2] Async/await documentation; fix for Underscore templating #4351
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ad4a6c4
doc fixes and updates
acb3c8d
changed wording
327395d
change async code snippet
43e5803
change async code snippet
993f459
switch to interactive sound example
ea3f044
refine sound example
8b1c109
eliminate utterance queuing
dc25f46
keeping it simple
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
concatPages = (urls) -> | ||
string = "" | ||
for url in urls | ||
# fetchURL returns a 'thenable' A+/Promise object | ||
string += await fetchURL(url) | ||
string | ||
|
||
concatPages([page, otherPage, yetAnother]) | ||
.then (string) -> | ||
console.log "Concatenation result: #{string}" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -829,7 +829,7 @@ Block | |
|
||
<p> | ||
<span id="fat-arrow" class="bookmark"></span> | ||
<b class="header">Bound Functions, Generator Functions</b> | ||
<b class="header">Function Modifiers</b> | ||
In JavaScript, the <code>this</code> keyword is dynamically scoped to mean the | ||
object that the current function is attached to. If you pass a function as | ||
a callback or attach it to a different object, the original value of <code>this</code> | ||
|
@@ -857,9 +857,9 @@ Block | |
constructed. | ||
</p> | ||
<p> | ||
CoffeeScript functions also support | ||
<a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/function*">ES6 generator functions</a> | ||
through the <code>yield</code> keyword. There's no <code>function*(){}</code> | ||
CoffeeScript also supports | ||
<a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/function*">generator functions</a> and <a href="https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/async_function">async functions</a> | ||
through the <code>yield</code> and <code>await</code> keywords respectively. There's no <code>function*(){}</code> or <code>async function(){}</code> | ||
nonsense — a generator in CoffeeScript is simply a function that yields. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
</p> | ||
<%= codeFor('generators', 'ps.next().value') %> | ||
|
@@ -868,6 +868,15 @@ Block | |
may be used if you need to force a generator that doesn't yield. | ||
</p> | ||
|
||
<p> | ||
Likewise, an async function in CoffeeScript is simply a function that awaits. | ||
</p> | ||
<%= codeFor('async') %> | ||
<p> | ||
Similar to how <code>yield return</code> forces a generator, <code>await return</code> | ||
may be used to force a function to be async. | ||
</p> | ||
|
||
<p> | ||
<span id="embedded" class="bookmark"></span> | ||
<b class="header">Embedded JavaScript</b> | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What did you fix here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The newer Underscore has a different templating API.