Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CS2] Failing test rejecting inconsistent whitespace in .litcoffee files #4336

Closed
GeoffreyBooth opened this issue Oct 10, 2016 · 3 comments
Closed
Labels
Milestone

Comments

@GeoffreyBooth
Copy link
Collaborator

@eelco Since #4313 was merged into 2, there is one failing test:

failed 1 and passed 724 tests in 2.05 seconds

  test/literate.litcoffee:56:5: error: indentation mismatch
                test "tabbed code", ->
                ^

If I delete everything above this test in literate.litcoffee, leaving just:

Tabs work too:

                test "tabbed code", ->
                    ok yes

Then this test passes. See comment.

@GeoffreyBooth
Copy link
Collaborator Author

Could #3924 help with this? That seems like a worthy PR in its own right.

@GeoffreyBooth
Copy link
Collaborator Author

@jashkenas @lydell what do you want to do about this? It’s causing issues with other 2-branch pull requests to have this broken test in the 2 branch. Should we comment it out or delete it until this issue is patched? Split the test into a separate .litcoffee file that only uses tabs (which doesn’t fix this issue, but rather simply makes the test pass)? Or roll back #4313 until this is fixed?

@GeoffreyBooth
Copy link
Collaborator Author

Update: potential fix in #4345.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant