ImportError: cannot import name 'soft_unicode' from 'markupsafe'

[akhiljalagam]

os: arch linux
python: 3.10.4
pip: 22.0.4
install method: pip3 install "buku[server]"
$ bukuserver run --host 127.0.0.1 --port 5001

Traceback (most recent call last):
  File "/opt/bukuserver/env/bin/bukuserver", line 5, in <module>
    from bukuserver.server import cli
  File "/opt/bukuserver/env/lib/python3.10/site-packages/bukuserver/server.py", line 11, in <module>
    from flask.cli import FlaskGroup
  File "/opt/bukuserver/env/lib/python3.10/site-packages/flask/__init__.py", line 14, in <module>
    from jinja2 import escape
  File "/opt/bukuserver/env/lib/python3.10/site-packages/jinja2/__init__.py", line 12, in <module>
    from .environment import Environment
  File "/opt/bukuserver/env/lib/python3.10/site-packages/jinja2/environment.py", line 25, in <module>
    from .defaults import BLOCK_END_STRING
  File "/opt/bukuserver/env/lib/python3.10/site-packages/jinja2/defaults.py", line 3, in <module>
    from .filters import FILTERS as DEFAULT_FILTERS  # noqa: F401
  File "/opt/bukuserver/env/lib/python3.10/site-packages/jinja2/filters.py", line 13, in <module>
    from markupsafe import soft_unicode
ImportError: cannot import name 'soft_unicode' from 'markupsafe' (/opt/bukuserver/env/lib/python3.10/site-packages/markupsafe/__init__.py)

[akhiljalagam]

fixed with pip install MarkupSafe==2.0.1

[rachmadaniHaryono]

pallets/markupsafe#286

pip3 install markupsafe==2.0.1

based on this elastic/ecs#1804

i may create pr tomorrow

[jarun]

@rachmadaniHaryono can you please take a look why docs build is failing?

I see:

ModuleNotFoundError: No module named 'myst_parser'

[rachmadaniHaryono]

actually markupsafe already pinned to 2.0.1

buku/bukuserver/requirements.txt

Line 17 in 73df4ce

markupsafe==2.0.1

buku/setup.py

Line 52 in 73df4ce

"markupsafe==2.0.1",

so i assume pypi version don't have this yet, maybe put this on changelog forr next release

---

@jarun,

i just notice you talk about the same problem about a month, sorry for not noticing it till now

73df4ce#commitcomment-70231928

can you point me where the failed docs build?

that error should not happen because myst-parser is required for doc

buku/setup.py

Line 91 in 73df4ce

"myst-parser>=0.17.0",

---

imo this issue can be closed

fixed by #573

i'm also not home for next two week, so expect late reply

[jarun]

For the docs failure: https://readthedocs.org/projects/buku/builds/16537740/

[jarun]

In case you are not able to see the build details, login with Github account details and I will add you as a maintainer.