Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build tsdx with tsdx #381

Open
jaredpalmer opened this issue Dec 19, 2019 · 2 comments
Open

build tsdx with tsdx #381

jaredpalmer opened this issue Dec 19, 2019 · 2 comments
Labels
scope: internal Changes only affect the internal API

Comments

@jaredpalmer
Copy link
Owner

We could compile tsdx with tsdx by first running it through tsc and then running it on itself.

We would need to change the repo's tsc outDir to something like tmp and then we would just run node ./tmp/index.js build ./tmp/index.js --tsconfig=tsconfig.compile.json. We would probs need to tweak tsconfig to make it work.

Kind of cool though. Probably useless.

@agilgur5
Copy link
Collaborator

Had been thinking of doing this too for dogfooding, but didn't see much of a point to it (would probably be slower to build too).

Could also use ts-node to simplify the above. Is there a reason ts-node isn't used internally? E.g. tests depend on the built dist/ files, which can be out-of-date (have tested the wrong version multiple times now); with ts-node could always use the current version. Can send a PR to improve the tests with it if there isn't anything against it

@agilgur5
Copy link
Collaborator

agilgur5 commented Aug 21, 2020

Not sure why neither of us wrote this, but actually the ideal way would be to use an old version of TSDX to build itself, as compilers or buildchains more broadly try to do.

build is the only piece that isn't dogfooded (well and create), so that would be one more type of self-integration test (could also do build with old version, re-build with currently built version).

I'm also looking to add project integration tests, e.g. building immer with a new version of TSDX and seeing if there are any breaking changes or, if it could run tests on dist code, seeing if those still pass

@agilgur5 agilgur5 changed the title hipster: build tsdx with tsdx build tsdx with tsdx Oct 22, 2020
@agilgur5 agilgur5 added scope: internal Changes only affect the internal API and removed fun labels Oct 22, 2020
@agilgur5 agilgur5 added this to the Future Non-breaking milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: internal Changes only affect the internal API
Projects
None yet
Development

No branches or pull requests

2 participants