Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default github workflow has old version of node - throws error #1104

Closed
SuperWallaby opened this issue Dec 18, 2021 · 1 comment
Closed

Default github workflow has old version of node - throws error #1104

SuperWallaby opened this issue Dec 18, 2021 · 1 comment
Labels
scope: templates Related to an init template, not necessarily to core (but could influence core) solution: duplicate This issue or pull request already exists

Comments

@SuperWallaby
Copy link

SuperWallaby commented Dec 18, 2021 •
edited
Loading

Current Behavior

If you do npx tsdx create mylib and select the base and push it, an error occurs in the github flow.
The error content is that node 10.x is not compatible with the dependency @size-limit/[email protected]: module.

Suggested solution(s)

main.yml

...
    strategy:
      matrix:
        node: ['10.x', '12.x', '14.x']
        os: [ubuntu-latest, windows-latest, macOS-latest]
...

should be

...
    strategy:
      matrix:
        node: [ '12.x', '14.x']
        os: [ubuntu-latest, windows-latest, macOS-latest]
...

then it works fine.
@SuperWallaby SuperWallaby changed the title default github flow has wrong version of node Default github workflow has wrong version of node Dec 18, 2021
@agilgur5 agilgur5 changed the title Default github workflow has wrong version of node Default github workflow has old version of node - throws error Apr 11, 2022
@agilgur5 agilgur5 added the scope: templates Related to an init template, not necessarily to core (but could influence core) label Apr 11, 2022
@agilgur5
Copy link
Collaborator

Duplicate of #1089

Thanks for providing a quick fix for readers. Other method is to pin size-limit to a version that supports Node 10.

@agilgur5 agilgur5 added the solution: duplicate This issue or pull request already exists label Apr 11, 2022
Repository owner locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
scope: templates Related to an init template, not necessarily to core (but could influence core) solution: duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agilgur5 @SuperWallaby