Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: WinVaultKeyring.get_credential with non-existent username returns credential of other user (#698) #699

Merged
merged 8 commits into from
Oct 26, 2024
Merged

Bugfix: WinVaultKeyring.get_credential with non-existent username returns credential of other user (#698) #699

merged 8 commits into from
Oct 26, 2024

Conversation

JamieBeverley
Copy link

Regarding #698

@jaraco jaraco mentioned this pull request Oct 26, 2024
Open
jaraco
jaraco approved these changes Oct 26, 2024
View reviewed changes
Copy link
Owner

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I'm going to do a bit of subsequent work to reorganize.

keyring/backends/Windows.py Outdated Show resolved Hide resolved
keyring/backends/Windows.py Outdated Show resolved Hide resolved
keyring/backends/Windows.py Outdated Show resolved Hide resolved
@jaraco
Copy link
Owner

jaraco commented Oct 26, 2024

I've always bemoaned that get_credential and get_password both had logic for resolving a credential. With 5e4b99e, that behavior is now unified and the tests still pass.

@jaraco jaraco merged commit ccaee76 into jaraco:main Oct 26, 2024
14 of 16 checks passed
@jaraco jaraco mentioned this pull request Oct 26, 2024
Closed
@JamieBeverley JamieBeverley deleted the bugfix/wrong_username branch October 27, 2024 12:52
@JamieBeverley
Copy link
Author

Thanks @jaraco - appreciate the comments + improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaraco jaraco jaraco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieBeverley @jaraco