You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
Unfortunately it doesn't seem like there are predefined schemas for secrets in the freedesktop secretservice backend, other than for network servers. Keytar chose to use account and keyring chose username. Setting both fields would allow the libraries to interoperate. Alternatively, giving the user the ability to override the schema would allow them to fix this themselves, but then it's still likely that different library developers would choose incompatible schemas.
keytar is the most popular keychain library on NPM, so sharing a common schema would be likely to increase compatibility with Node applications that interface with common services.
Happy to align with established patterns. I'd recommend the pattern that is dominant (>70% users) or established first should take precedence. Under that recommendation, which system should change?
If keyring were to change, there would need to be a transition and probably a migration process. It'll be an involved transition. Is that something you'd be willing to own (or sponsor)?
Describe the bug
Unfortunately it doesn't seem like there are predefined schemas for secrets in the freedesktop secretservice backend, other than for network servers. Keytar chose to use
account
and keyring choseusername
. Setting both fields would allow the libraries to interoperate. Alternatively, giving the user the ability to override the schema would allow them to fix this themselves, but then it's still likely that different library developers would choose incompatible schemas.keytar is the most popular keychain library on NPM, so sharing a common schema would be likely to increase compatibility with Node applications that interface with common services.
https://github.com/atom/node-keytar/blob/master/src/keytar_posix.cc#L14-L17
https://github.com/jaraco/keyring/blob/master/keyring/backends/SecretService.py#L84-L87
To Reproduce
Steps to reproduce the behavior:
[it fails]
Expected behavior
The secret should be returned
Environment
The text was updated successfully, but these errors were encountered: