Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update tekton and quay plugin #881

Closed
wants to merge 1 commit into from
Closed

chore(deps): update tekton and quay plugin #881

wants to merge 1 commit into from

Conversation

karthikjeeyar
Copy link
Contributor

Description

Update tekton and quay plugin to include the latest features and fixes.

Which issue(s) does this PR fix

Tekton Features:

  • Add CVE summary as a column in Pipelinerun list view - #986
  • Add signed badge for PipelineRuns that are signed by chains - #987
  • Add view sbom and view logs actions column in the pipelineRun list page - #988
  • Add download logs action - #878

Quay Fixes:

  • security scan column is loading forever for .sbom, .att and .sig tags - #989
  • Vulnerability list page should be sorted by severity - #990
  • Vulnerability list page should be sorted by severity #1032

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@karthikjeeyar karthikjeeyar requested a review from a team as a code owner January 11, 2024 10:11
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: a861e17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
dynamic-plugins-imports Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@karthikjeeyar karthikjeeyar force-pushed the update-tekton-quay-plugin branch from 37b7a8a to b1ba770 Compare January 11, 2024 10:13
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-881!

@karthikjeeyar karthikjeeyar force-pushed the update-tekton-quay-plugin branch from b1ba770 to 81c2640 Compare January 11, 2024 11:03
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-881!

@janus-idp Janus IDP
Copy link
Contributor

janus-idp bot commented Jan 11, 2024 •
edited
Loading

backstage-showcase Tests on commit 5c13cb9 finished with errors.
View test log

@karthikjeeyar
Copy link
Contributor Author

/retest

@karthikjeeyar karthikjeeyar force-pushed the update-tekton-quay-plugin branch from 81c2640 to 36ae2a4 Compare January 15, 2024 07:42
@karthikjeeyar karthikjeeyar requested a review from tumido January 15, 2024 07:58
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-881!

@invincibleJai
Copy link
Member

Verified the changes and looks good

Tekton:

image

Quay:

image

@invincibleJai
Copy link
Member

/approve

Zaperex
Zaperex requested changes Jan 22, 2024
View reviewed changes
dynamic-plugins/imports/package.json Outdated Show resolved Hide resolved
@karthikjeeyar karthikjeeyar force-pushed the update-tekton-quay-plugin branch from 36ae2a4 to c982360 Compare January 23, 2024 05:53
@karthikjeeyar karthikjeeyar force-pushed the update-tekton-quay-plugin branch from c982360 to a861e17 Compare January 23, 2024 05:56
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@karthikjeeyar karthikjeeyar requested a review from Zaperex January 23, 2024 05:56
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-881!

@debsmita1
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 23, 2024
@Zaperex
Copy link
Member

Zaperex commented Jan 23, 2024

/lgtm

@Zaperex
Copy link
Member

Zaperex commented Jan 23, 2024

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debsmita1, invincibleJai, Zaperex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Zaperex,invincibleJai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@schultzp2020
Copy link
Member

No longer needed #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumido tumido Awaiting requested review from tumido

@Zaperex Zaperex Awaiting requested review from Zaperex

Assignees

@debsmita1 debsmita1

@Zaperex Zaperex

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@karthikjeeyar @invincibleJai @debsmita1 @Zaperex @schultzp2020