Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamic-plugins): use segment as a dynamic plugin #812

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

tumido
Copy link
Member

@tumido tumido commented Nov 22, 2023

Description

SSIA, makes segment frontend plugin dynamic

Which issue(s) does this PR fix

Requires janus-idp/backstage-plugins#955, waiting for requirements to be met

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@tumido tumido requested a review from a team as a code owner November 22, 2023 23:14
Copy link

changeset-bot bot commented Nov 22, 2023

🦋 Changeset detected

Latest commit: b1ae45b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
dynamic-plugins-imports Patch
app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tumido tumido added the cherry-pick-1.0.x This PR should be cherry-picked to the 1.0.x branch label Nov 22, 2023
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-812!

@kadel kadel merged commit 6395082 into janus-idp:main Nov 24, 2023
6 checks passed
@kadel kadel added the cherry-pick-OK This PR was successfully cherry-picked to the appropriate branch. label Nov 24, 2023
kadel pushed a commit to kadel/backstage-showcase that referenced this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-1.0.x This PR should be cherry-picked to the 1.0.x branch cherry-pick-OK This PR was successfully cherry-picked to the appropriate branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants