Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): fixin rbac tests #2045

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

test(e2e): fixin rbac tests #2045

wants to merge 29 commits into from

Conversation

nilgaar
Copy link
Contributor

@nilgaar nilgaar commented Dec 3, 2024

Description

Please explain the changes you made here.

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.4% Duplication on New Code

See analysis details on SonarQube Cloud

@nilgaar
Copy link
Contributor Author

nilgaar commented Dec 3, 2024

/test-all

@nilgaar
Copy link
Contributor Author

nilgaar commented Dec 3, 2024

/ready-to-test

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

The image is available at:

@nilgaar
Copy link
Contributor Author

nilgaar commented Dec 3, 2024

/ok-to-test

@nilgaar
Copy link
Contributor Author

nilgaar commented Dec 3, 2024

/test all

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

The image is available at:

@nilgaar
Copy link
Contributor Author

nilgaar commented Dec 3, 2024

/test all

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024

The image is available at:

@nilgaar
Copy link
Contributor Author

nilgaar commented Dec 3, 2024

/test all

@nilgaar nilgaar marked this pull request as ready for review December 3, 2024 17:33
@nilgaar nilgaar requested a review from a team as a code owner December 3, 2024 17:33
@openshift-ci openshift-ci bot requested a review from subhashkhileri December 3, 2024 17:34
@nilgaar nilgaar changed the title Rhidp 4264 3 test(e2e): fixin rbac tests Dec 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from nilgaar. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@github-actions GitHub Actions
Copy link
Contributor

The image is available at:

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 13, 2024

@nilgaar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 651d2f1 link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subhashkhileri subhashkhileri Awaiting requested review from subhashkhileri

@zdrapela zdrapela Awaiting requested review from zdrapela

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nilgaar @openshift-merge-robot