Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the scaffolder relation processor plugin #1299

Merged

Conversation

Zaperex
Copy link
Member

@Zaperex Zaperex commented Jun 4, 2024

Description

Add the scaffolder relation processor plugin into the showcase and enable by default as it does not require any additional configurations.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@Zaperex Zaperex requested a review from a team as a code owner June 4, 2024 14:45
@openshift-ci openshift-ci bot requested review from kadel and PatAKnight June 4, 2024 14:45
@Zaperex Zaperex requested a review from schultzp2020 June 4, 2024 14:47
Copy link
Contributor

github-actions bot commented Jun 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1299!

@gashcrumb
Copy link
Member

/retest

@openshift-ci openshift-ci bot removed the lgtm label Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1299!

@gashcrumb gashcrumb added the lgtm label Jun 4, 2024
@openshift-ci openshift-ci bot removed the lgtm label Jun 4, 2024
Copy link

sonarcloud bot commented Jun 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Jun 4, 2024

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1299!

@Zaperex Zaperex requested a review from nickboldt June 4, 2024 19:58
@gashcrumb
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gashcrumb, nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [gashcrumb,nickboldt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e1e6215 into janus-idp:main Jun 5, 2024
8 checks passed
@Zaperex Zaperex deleted the add-scaffolder-from-processor branch June 5, 2024 13:24
@Zaperex
Copy link
Member Author

Zaperex commented Jun 5, 2024

/cherry-pick 1.2.x

@openshift-cherrypick-robot

@Zaperex: only janus-idp org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@schultzp2020
Copy link
Member

/cherry-pick 1.2.x

@openshift-cherrypick-robot

@schultzp2020: new pull request created: #1303

In response to this:

/cherry-pick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants