From 04df020562d99746f45d7614fa220c266b2cdcc4 Mon Sep 17 00:00:00 2001 From: Nil Gallego Date: Wed, 4 Dec 2024 15:51:28 +0100 Subject: [PATCH] docs: adding general rules to e2e contribution guidelines (#1966) * adding general rules * Update CONTRIBUTING.MD --- docs/e2e-tests/CONTRIBUTING.MD | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/docs/e2e-tests/CONTRIBUTING.MD b/docs/e2e-tests/CONTRIBUTING.MD index 6f36164e3a..7353956d4a 100644 --- a/docs/e2e-tests/CONTRIBUTING.MD +++ b/docs/e2e-tests/CONTRIBUTING.MD @@ -37,6 +37,13 @@ These principles are valid for new contributions. Some parts of the codebase may All architecture principles and guidelines must be agreed upon by the team. Every team member's voice is important, and open communication ensures alignment and shared understanding of the project's direction. +6. **General Rules** + + All tests have to follow a set of simple rules: + I. Check the preconditions. If tests are running in parallel, try to create the preconditions you need to avoid race conditions. + II. Each test has to test one and only one thing. + III. All tests have to contain preconditions, actions, and assertions, like you whould do in [Gherkin](https://cucumber.io/docs/guides/overview/); think in those terms. + #### Technical Guidelines 1. **Page Object Model (POM)**