Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): allow mutable install for monorepo yarn.lock #2408

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

gashcrumb
Copy link
Member

This change updates the CLI to use --no-immutable when a plugin package or monorepo yarn.lock file is used during the export-dynamic-plugin command. Explicitly passing this flag avoids the default Yarn 3.x behavior of --immutable when the command is run in a CI environment.

@schultzp2020 @davidfestal fyi

This change updates the CLI to use `--no-immutable` when a plugin package or
monorepo `yarn.lock` file is used during the `export-dynamic-plugin` command.
Explicitly passing this flag avoids the default Yarn 3.x behavior of
`--immutable` when the command is run in a CI environment.

Signed-off-by: Stan Lewis <[email protected]>
@gashcrumb gashcrumb requested review from a team as code owners October 21, 2024 17:16
Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: abe82bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@janus-idp/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarcloud bot commented Oct 21, 2024

Copy link
Member

@schultzp2020 schultzp2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Oct 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 326bca2 into janus-idp:main Oct 21, 2024
9 checks passed
04kash pushed a commit to 04kash/backstage-plugins that referenced this pull request Oct 23, 2024
This change updates the CLI to use `--no-immutable` when a plugin package or
monorepo `yarn.lock` file is used during the `export-dynamic-plugin` command.
Explicitly passing this flag avoids the default Yarn 3.x behavior of
`--immutable` when the command is run in a CI environment.

Signed-off-by: Stan Lewis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants