Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix the embed-as-dependencies option on the export-dynamic-plugin CLI... #1478

Merged
merged 1 commit into from
Apr 8, 2024
Merged

fix(cli): fix the embed-as-dependencies option on the export-dynamic-plugin CLI... #1478

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/cli/src/commands/export-dynamic-plugin/backend-embed-as-dependencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ export async function backend(opts: OptionValues): Promise<string> {
pkg,
packagesToEmbed,
monoRepoPackages,
createRequire(paths.targetDir),
createRequire(`${paths.targetDir}/package.json`),
[],
);
const embeddedPackages = embeddedResolvedPackages.map(e => e.packageName);
Expand Down Expand Up @@ -731,7 +731,7 @@ function isPackageShared(
}

function validatePluginEntryPoints(target: string): string {
const dynamicPluginRequire = createRequire(target);
const dynamicPluginRequire = createRequire(`${target}/package.json`);

// require plugin main module

Expand Down
Loading