Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): migrate from openapi to openapi-ts #1464

Merged
merged 6 commits into from
Apr 9, 2024
Merged

chore(deps): migrate from openapi to openapi-ts #1464

merged 6 commits into from
Apr 9, 2024

Conversation

schultzp2020
Copy link
Member

Migrate from openapi (deprecated) to openapi-ts

@schultzp2020 schultzp2020 requested a review from a team as a code owner April 5, 2024 15:37
@nickboldt nickboldt self-requested a review April 5, 2024 15:56
nickboldt
nickboldt reviewed Apr 5, 2024
View reviewed changes
Copy link
Member

@nickboldt nickboldt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable other than the usual test failures.

Error: @janus-idp/backstage-scaffolder-backend-module-servicenow#test: command (/home/runner/work/backstage-plugins/backstage-plugins/plugins/servicenow-actions) yarn run test exited (1)

Is this a case where after we merge this the tests will work for subsequent runs, but this is a temporarily breaking change that affects the tests?

@schultzp2020
fix test cases
6c31f6d 
Signed-off-by: Paul Schultz <[email protected]>
@schultzp2020
Copy link
Member Author

/retest

@schultzp2020
Copy link
Member Author

@nickboldt PTAL?

@nickboldt
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nickboldt nickboldt added the lgtm label Apr 9, 2024
@nickboldt nickboldt merged commit 0ccdeef into janus-idp:main Apr 9, 2024
9 of 11 checks passed
@nickboldt
Copy link
Member

Paul says "just merge it anyway" so here we go...

@schultzp2020 schultzp2020 deleted the migrate-openapi-ts branch September 25, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickboldt nickboldt nickboldt left review comments

@AndrienkoAleksandr AndrienkoAleksandr Awaiting requested review from AndrienkoAleksandr

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

Assignees
No one assigned
Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schultzp2020 @nickboldt @openshift-merge-robot