Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kiali): namespaceSelector is removing options #1186

Merged

Conversation

aljesusg
Copy link
Contributor

@aljesusg aljesusg commented Feb 8, 2024

When you remove a namespace in selector, this option is removed from items. The behaviour should be keep the namespace unselected.

Before Fix

before_fix.webm

After fix

after_fix.webm

@aljesusg aljesusg requested a review from a team as a code owner February 8, 2024 09:01
Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@josunect josunect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bug is Fixed:

image

Copy link

openshift-ci bot commented Feb 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josunect

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 0195b06 into janus-idp:main Feb 8, 2024
9 checks passed
@aljesusg aljesusg deleted the fix_namespace_selector branch February 8, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants