Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quay): fix sorting and ordering of vulneribilities based on severity #1033

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

rohitkrai03
Copy link
Contributor

@rohitkrai03 rohitkrai03 commented Dec 20, 2023

Fixes: #1032

Fixes: #990

Description

  • Fixed the ordering of vulnerabilities in tags list page based on severity.
  • Fixed the sorting of vulnerabilities in vulnerabilities list page based on severity.

Screencast

Before

Screen.Recording.2023-12-20.at.2.59.39.PM.mov

After

Screen.Recording.2023-12-20.at.6.03.28.PM.mov
Screen.Recording.2023-12-21.at.12.07.17.PM.mov

@rohitkrai03 rohitkrai03 changed the title fix(quay): fix ordering of vulneribilities based on severity fix(quay): fix sorting and ordering of vulneribilities based on severity Dec 21, 2023
Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vulnerability column value order and sorting on vulnerability details page works as expected.
LGTM

@rohitkrai03
Copy link
Contributor Author

Vulnerability column value order and sorting on vulnerability details page works as expected.

I noticed SECURITY SCAN column is missing sorting, good to have this fixed as well, wdyt?

sorting_security_scan sorting_security_scan

The sorting will work to some extent after the fix for infinite loader goes in. Although we do need proper sort handlers for both of the tables (The current ones are the default MUI ones) and that involves a lot more work than what is scope in our current tickets. I feel that work might be another feature in itself which we can track as a separate ticket. WDYT?

@karthikjeeyar
Copy link
Contributor

karthikjeeyar commented Dec 21, 2023

@rohitkrai03 I agree that it is out of scope for this fix, I will log a new feature request for sorting capabilities. Thanks

Created a feature request - #1034

Copy link
Member

@invincibleJai invincibleJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@invincibleJai invincibleJai merged commit d3fdcdf into janus-idp:main Dec 21, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants