-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(quay): fix sorting and ordering of vulneribilities based on severity #1033
Conversation
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vulnerability column value order and sorting on vulnerability details page works as expected.
LGTM
The sorting will work to some extent after the fix for infinite loader goes in. Although we do need proper sort handlers for both of the tables (The current ones are the default MUI ones) and that involves a lot more work than what is scope in our current tickets. I feel that work might be another feature in itself which we can track as a separate ticket. WDYT? |
@rohitkrai03 I agree that it is out of scope for this fix, I will log a new feature request for sorting capabilities. Thanks Created a feature request - #1034 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes: #1032
Fixes: #990
Description
Screencast
Before
Screen.Recording.2023-12-20.at.2.59.39.PM.mov
After
Screen.Recording.2023-12-20.at.6.03.28.PM.mov
Screen.Recording.2023-12-21.at.12.07.17.PM.mov