-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rbac): add vscode debug test configuration for rbac-backend #1025
Conversation
Signed-off-by: Oleksandr Andriienko <[email protected]>
9c0cd0b
to
64cc703
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
@AndrienkoAleksandr i tried to test it on launching debug in VScode , i see below in terminal. Any help with what am i missing? |
@invincibleJai, you need to select a rbac-backend test and add a breakpoint. Then it's working fine for me. And I really like it 👍 From my side we can merge this if this helps people. I have just two suggestions / ideas:
I tried this launch setting and it spams the console with some more warning, but on the first look it's working as well? {
"version": "1.0.0",
"configurations": [
{
"type": "node",
"request": "launch",
"name": "Current selected test",
"program": "${workspaceRoot}/node_modules/.bin/backstage-cli",
"args": ["package", "test", "${relativeFile}"],
"console": "integratedTerminal",
"internalConsoleOptions": "neverOpen",
}
]
} @AndrienkoAleksandr can you take a look if this working for you? |
@jerolimov , hello. I tested your vscode configuration. It works fine for rbac-backend-plugin.
Looks like, we can. You provided plenty universal configuration.
It is required for my pull request, because my vscode configuration uses original jest binary and It needs typescript transformer and parser.
I guess you proposed configuration with --watch by default, because when I modify test file, then debugger executes test one more time. That's --watch behavior from my point of view. @jerolimov I think you can create pull request with your idea, then I can close my pull request on favor yours. |
@AndrienkoAleksandr Feel free to take my json and update your PR with these changes, with or without ts-lint. I'm back next week and vscode lanucher isn't a prio for me currently. ;) I'm also fine if we merge your PR in its current form and improve later if needed. |
@jerolimov ok, I close this pull request on favor #1047 |
What doest this pull request do:
Add ability to debug opened and selected test files for rbac-backend plugin in the vscode.