Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback plugin #1680

Closed
boueida opened this issue May 16, 2024 · 3 comments
Closed

Feedback plugin #1680

boueida opened this issue May 16, 2024 · 3 comments
Assignees
@yashoswalyo
Labels
kind/bug Something isn't working plugin/feedback status/triage

Comments

@boueida
Copy link

boueida commented May 16, 2024

Describe the bug

When creating the annotations in catalog-info, we have to specify all the annotations or else the plugin won't work and will show that:
image

Expected Behavior

The optional feedback/email-to has to be optional and not required.

What are the steps to reproduce this bug?

Create a catalog-info as instructed and don't add feedback/email-to
@boueida boueida added kind/bug Something isn't working status/triage labels May 16, 2024
@github-actions github-actions bot added the jira label May 16, 2024
@riginoommen
Copy link
Member

/assign @yashoswalyo

@jasperchui jasperchui removed the jira label May 17, 2024
@yashoswalyo
Copy link
Member

Fixed in #1696
Now only feedback/type annotation is required in your catalog-info file

@yashoswalyo
Copy link
Member

@boueida can you verify and close this issue?

@boueida boueida closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yashoswalyo yashoswalyo

Labels
kind/bug Something isn't working plugin/feedback status/triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@riginoommen @jasperchui @yashoswalyo @boueida