New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Topology: Show decorator in topology for ingress associated to any deployment #123

Closed

2 tasks done

Tracked by

invincibleJai opened this issue Feb 14, 2023 · 1 comment

Closed

2 tasks done

Tracked by

App Topology: Show decorator in topology for ingress associated to any deployment #123

invincibleJai opened this issue Feb 14, 2023 · 1 comment

Assignees

Member

invincibleJai commented Feb 14, 2023 •

edited

Loading

Description: As a user I would like to see the decorator on the deployment node in the topology view if the associated ingress exists

Acceptance Criteria:

Show decorator in topology for ingress associated with any deployment
Decorator should be clickable and should take to the URL in new tab

invincibleJai mentioned this issue

🔌 UI Plugin: Application Topology #58

Closed

18 tasks

rtaniwa added the kind/story label

invincibleJai self-assigned this

invincibleJai mentioned this issue

feat(topology): adds support for decorator in topology for ingress #148

Merged

3 tasks

Member Author

invincibleJai commented Feb 28, 2023

Associated PR #148

invincibleJai added a commit that referenced this issue


          feat(topology): adds support for decorator in topology for ingress (#148

05d17c2

)

**Tracks:** #58

**Fixes:**  #123

**Screenshots/GIF's:**
- Light Theme

![image](https://user-images.githubusercontent.com/5129024/222737536-9a99e65b-1863-4c92-a028-aa209bd5f722.png)



- Dark Theme

![image](https://user-images.githubusercontent.com/5129024/222737316-ded9036c-1292-47c0-8a0d-bab8eb125d6f.png)




**Test Setup:**
Follow
https://github.com/janus-idp/backstage-plugins/tree/main/plugins/topology#readme

**Unit Tests:**
<img width="1260" alt="image"
src="https://user-images.githubusercontent.com/5129024/223665084-9b179808-3d23-4d32-963f-01efef16db5b.png">


**Todo:**
- [x] adds support for decorator in topology for ingress
- [x] adds accessibility styles from pf (for control bars)
- [x] add unit tests

---------

Co-authored-by: Jeffrey Phillips <[email protected]>

invincibleJai closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment