[WIP] Improve performance by reducing unnecessary calls to stats. #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asolove
changed the title
Getting the full build stats can be very expensive, and has to happen for each child compiler. So let's avoid it in cases where we just need specific data from the compilation. - Get hash straight off compilation - Get chunks off compilation (and update some differences between actual chunk objects and chunk stats)
asolove
force-pushed
the
perf-avoid-stats
branch
from
18d9f3d
to
2007106
Compare
|
Not sure why the tests pass locally and fail on CI, but I apparently opened this too hastily and need to look into it more. |
|
#723 duplicate |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the full build stats can be very expensive, and has to happen for each child compiler. So let's avoid it in cases where we just need specific data from the compilation.
We have a webpack stress test using the multipage plugin (which uses this plugin). In that test, removing these stats serializations reduced the runtime from 38s to 26s on my machine.