Remove lodash as dependency, fix #172 #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about |
|
@jantimon A better solution 😄 |
jantimon
added a commit
that referenced
this pull request
Jan 15, 2016
Fix lodash as dependency #172
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes changes included with
commit b3913d04001f031342794c71acfc4a1bae4e01b3.Why?
commit b3913dmakeslodasha dependency for user's app. Not every user will uselodash. Those who don't use lodash will run into error.[email protected]to[email protected], my build script crashed because of reason above. Thecommit b3913dleads to incompatibility.escapeis not that important and we have other approach.More details: