-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #259: Finish Feature Request by Adding Support for musllinux Wheels and Testing Script for Alpine Compatibility #261
base: master
Are you sure you want to change the base?
Conversation
Thank you for the contribution and the nice summary of changes.
Thank you |
…bally using variable CIBW_BUILD_VERSIONS
@jannikmi hi, thanks for the review! I've merged the make-musllinux-wheels job into the existing make-wheels job. This ensures code consistency and uses pypa/[email protected]. And i've defined CIBW_BUILD_VERSIONS globally with required py versions. Could u take a look? |
@Pxli9130 Thanks, that now looks a lot cleaner (less repetition). Could you please have a look at the actions run:
Could you please look into this? Why is |
sure, i'll check it |
…is is caused by the absence of `yum` in Alpine-based musllinux images
@jannikmi The issue occurs because the musllinux Docker images used in the build are based on Alpine Linux, which uses |
Fixes #259
Description:
This pull request introduces support for building musllinux wheels, enabling users on Alpine Linux and other musl-based systems to install
timezonefinder
without the need for compiling from source. It also adds a testing script to verify the package's compatibility with Alpine Linux.Changes Introduced:
Updated
pyproject.toml
:cibuildwheel
as a development dependency.Added GitHub Actions Workflow
make-musllinux-wheels
:cibuildwheel
.Updated
poetry.lock
:pyproject.toml
by updating the lock file.Added Testing Script
test_musllinux_wheel.sh
:Benefits:
Enhanced Compatibility:
Improved Developer Experience:
Automated Builds:
Testing Performed:
Built musllinux Wheels:
Verified Functionality:
test_musllinux_wheel.sh
script to install and test the musllinux wheels in an Alpine Linux Docker container.Request for Review (Nov 23):
I kindly request the maintainers to review these changes. The addition of musllinux wheel support and the testing script should enhance the usability of
timezonefinder
for users on musl-based systems and streamline the development process for contributors.Please let me know if there are any questions or if further adjustments are needed. I'm happy to collaborate to ensure these changes align with the project's goals and standards.
Request for Review (Nov 25):
I have made the requested changes based on your feedback:
Combined the Wheel-Building Jobs:
make-wheels
andmake-musllinux-wheels
jobs into a singlemake-wheels
job.[email protected]
.Ensured Code Consistency:
cibuildwheel
action and configuration.Defined Python Versions Globally:
CIBW_BUILD_VERSIONS
to specify the supported Python versions, right now it's Python 3.8 to 3.13.Please review the updated changes. I believe these adjustments enhance the build process and align with the project's goals. Let me know if there's anything else you'd like me to adjust. I'm happy to collaborate to ensure these changes meet your expectations.
Request for Review (Nov 29):
I have addressed the issue based on the feedback, where the musllinux builds failed due to the use of
yum
, which is unavailable in musllinux (Alpine-based) images.Changes:
build.yml
to useapk add
for musllinux builds instead ofyum
.yum
) and musllinux (apk
) to ensure compatibility with their respective environments.These changes ensure that the musllinux builds work seamlessly, allowing the project to support musl-based systems effectively. The relevant changes for this issue are included in commit bd26666.
Please review the updates. I believe these changes further improve the build process and enhance compatibility for
timezonefinder
. Let me know if there are any questions or additional feedback!Thank you for considering this contribution!