Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab is a potential short-cut key too #1

Open
mtk opened this issue Jan 1, 2015 · 1 comment
Open

Tab is a potential short-cut key too #1

mtk opened this issue Jan 1, 2015 · 1 comment

Comments

@mtk
Copy link
Contributor

mtk commented Jan 1, 2015

When the plugin is activated, Tab switches between the two drop-down menus that choose the source and target keymaps. But Tab is a potential short-cut key too! I think it is more important to make Tab something that you can translate instead of something that navigates between plugin GUI elements. Thoughts/comments?

/mark

@janickr
Copy link
Owner

janickr commented Jan 14, 2015

This is probably because ShortcutTranslatorDialog extends DialogWrapper (from Intellij platform). It inherits the default intellij dialog behaviour. If I remember correctly, it was the easiest way to provide the plugin with consistent IntelliJ L&F (centering the dialog, giving it the correct size, registering default event handlers).
I'm guessing that Tab is not used a lot as a hotkey other than cycling through tabs & other UI elements, or indenting in the editor. This in combination with the fact that the intellij keymaps for competing editors are not complete anyway, makes the effort too big (for me) to change the way ShortcutTranslatorDialog is created without losing other Intellij behaviour.

Janick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants