Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_win.bat dist output contains "The system cannot find the file specified" #1495

Closed
sogaiu opened this issue Sep 6, 2024 · 1 comment
Labels
bug This is not expected behavior, and needs fixing

Comments

@sogaiu
Copy link
Contributor

sogaiu commented Sep 6, 2024

With c82fd10 (and likely before), I've noticed that here, build_win.bat dist invocation output contains:

"The system cannot find the file specified".

It looks like this comes from:

copy janet.def dist\janet.def

That line seems to have been added in this commit.

Looking at the cloned janet repository directory after building (e.g. after invoking build_win.bat successfully), I don't see janet.def. May be I'm doing something wrong?

Perhaps there is nothing to be concerned about here but FWIW.

@bakpakin bakpakin added the bug This is not expected behavior, and needs fixing label Sep 6, 2024
@bakpakin
Copy link
Member

bakpakin commented Sep 6, 2024

I don't think we really need janet.def anymore, it's an artifact from msvc to declare exported symbols. I think the better thing to do is just drop that from the build process.

Not an expert on this, but I would check microsoft documentation: https://learn.microsoft.com/en-us/cpp/build/exporting-from-a-dll-using-def-files?view=msvc-170

Basically, all exported symbols in Janet should be using __declspec(dllexport) (that is what the macro JANET_API resolves to on windows), so from the above documentation it is implied we don't need it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is not expected behavior, and needs fixing
Projects
None yet
Development

No branches or pull requests

2 participants