Feat: datasplit limit validation size #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appear to be some python formatting errors in 38a1b7e. This pull request uses the [psf/black](https://github.com/psf/black) formatter to fix these issues.
rhoadesScholar
previously approved these changes
Sep 10, 2024
| crop = True | ||
| max_idx = np.argmax(voxel_shape) | ||
| voxel_shape = Coordinate( | ||
| s if i != max_idx else s // 2 for i, s in enumerate(voxel_shape) |
There was a problem hiding this comment.
For the record, I don't like using s // 2...
There was a problem hiding this comment.
Consider a volume that is 100x100x110, but a max size of 100**3
This will reduce the volume to 100x100x55 instead of just getting to the max size :/
|
@mzouink Need to fix tests 😬 |
the reason was funlib persistence. should be good now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes i want to speedup validation so as option we can limit validation size:
max_validation_volume_size = 600**3