Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sublime Text 3103 JS Syntax Highlighting #122

Closed
alexmccabe opened this issue Feb 9, 2016 · 7 comments
Closed

Sublime Text 3103 JS Syntax Highlighting #122

alexmccabe opened this issue Feb 9, 2016 · 7 comments

Comments

@alexmccabe
Copy link

Since updating to ST3 3103 the syntax highlighting for JS files has changed, and has become much less clear. Now I'm wading through a sea of orange text. Every other syntax appears to be fine. In the changelog for the new update there is mention of changing the way syntax highlighting works, so I'm wondering whether a couple tweaks would sort it out? As you can see in the attached screenshot, variables and function names are the same colour, when this wasn't the case as far as I can recall.

screenshot 2016-02-09 09 44 41

@jamiewilson
Copy link
Owner

@alexmccabe Oh, bummer. I just updated and this is bad. Will take a look as soon as I can. Thanks for reporting.

@alexmccabe
Copy link
Author

It's no worries, and there's no way I will be switching off this theme because of it! I will endure ;) But there is no rush, at least not from my point of view anyway.

@jamiewilson
Copy link
Owner

@alexmccabe I couldn't deal with that. Had to resolve immediately :) Should hit Package Control within the hour.

Let me know if this works or if there are things that still aren't right. I think there were a handful of new syntax scopes added so I'm not sure I can replicate the way it used to be. At least it's not so much orange now though.

@epzee
Copy link

epzee commented Feb 10, 2016

@jamiewilson thanks for the quick fix, looks much better now! I think there are some more tweaks to be made. Check view., data. and APP.Utils. in this example:

screenshot 2016-02-10 00 55 35

@alexmccabe
Copy link
Author

Variables are still orange for me on the new update. I don't know if there is anything else I should be doing? I updated the package and restarted ST3.

screenshot 2016-02-10 12 19 18

@matejkramny
Copy link

screen shot 2016-02-10 at 13 27 49

Hello, these changes are too much!

The previous looked so much better, how can I downgrade?

@alexmccabe
Copy link
Author

Okay so ignore my previous screenshot, I didn't know that SublimeLinter copies the current syntax highlighting and forces you to use it's own version. Switching to your one I get a similar result to @matejkramny
screenshot 2016-02-15 09 21 01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants