Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans to make this work in vNext? #10

Open
georgiosd opened this issue Jun 15, 2015 · 13 comments
Open

Any plans to make this work in vNext? #10

georgiosd opened this issue Jun 15, 2015 · 13 comments

Comments

@georgiosd
Copy link

No description provided.

@jamiekurtz
Copy link
Owner

Definitely! Though admittedly haven't given it much thought yet.

Is it not working in vNext?

@jamiekurtz
Copy link
Owner

... also... OWIN support is something on the radar

@georgiosd
Copy link
Author

Uhm, I am under the impression the API has changed completely because of the new middleware?
I could be wrong.

@robianmcd
Copy link

Just tried using this in ASP.NET Core 1.0 and I get the error message "The dependency JWT 1.3.4 in project Mercury does not support framework DNXCore, Version=v5.0."

@jamiekurtz
Copy link
Owner

Interesting... I will try to take a look this coming weekend. I'm guessing
that the Microsoft JWT library itself doesn't work in new Core.

BTW - On what OS and version are you finding this error?

Jamie Kurtz
Solutions Architect and Consultant

http://www.jamiekurtz.com
http://www.jamiekurtz.com?utm_source=email&utm_medium=signature&utm_campaign=general
| https://twitter.com/jakurtz
http://www.linkedin.com/in/jamieakurtz | http://github.com/jamiekurtz

On Wed, Feb 10, 2016 at 9:30 AM, Rob [email protected] wrote:

Just tried using this in ASP.NET Core 1.0 and I get the error message
"The dependency JWT 1.3.4 in project Mercury does not support framework
DNXCore, Version=v5.0."


Reply to this email directly or view it on GitHub
#10 (comment)
.

@robianmcd
Copy link

I got the error on Windows 10

@BrandonClapp
Copy link

@jamiekurtz, I think @georgiosd is correct. For the vNext stuff you will need to create an OWIN middleware in order to support what is currently being done in WebApiConfig.Register() since this is the new way of tying in to the new HTTP request pipeline.

Additionally, Web API and MVC are now one and the same.

It may be worthwhile to create a separate repo for the vNext stuff since it will be drastically different.

@jamiekurtz
Copy link
Owner

Thanks @robianmcd and @BrandonClapp . At this point I don't have any plans to update this library to work with vNext/Core/OWIN. Happy to review or discuss further.

@johnvcoleman-w24
Copy link

@BrandonClapp I'm at the same crossroad now (would like to have this work with Core), did you guys fork this or cook up your own solution?

@robianmcd
Copy link

@johnvcoleman-w24
Copy link

Sweet. Thanks for the pointer @robianmcd and thanks @jamiekurtz, this package really made life simpler!

@BrandonClapp
Copy link

BrandonClapp commented Apr 17, 2017

@johnvcoleman-w24 This was for a side project and I don't think I ever followed through with implementing JWT in it.

That being said, I think there is a JWT authentication middleware in asp.net core found in the Microsoft.AspNetCore.Autnentication.JwtBearer nuget package.

A fairly descriptive explanation for the implementation can be found here: http://stackoverflow.com/a/39822153/1730061

Edit: it looks like this was the route @robianmcd took, too.

@johnvcoleman-w24
Copy link

@BrandonClapp thank you sir! 👍 I have some reading to do...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants