Skip to content
This repository has been archived by the owner on Jun 15, 2021. It is now read-only.

Latest commit

 

History

History
105 lines (70 loc) · 3.27 KB

CONTRIBUTING.rst

File metadata and controls

105 lines (70 loc) · 3.27 KB
Raw

Contributing

Contributions are welcome, and they are greatly appreciated! Every little bit helps, and credit will always be given.

You can contribute in many ways:

Types of Contributions

Report Bugs

Report bugs at https://github.com/murodese/pynab/issues.

If you are reporting a bug, please include:

  • Your operating system name and version.
  • Any details about your local setup that might be helpful in troubleshooting.
  • Detailed steps to reproduce the bug.

Fix Bugs

Look through the GitHub issues for bugs. Anything tagged with "bug" is open to whoever wants to implement it.

Implement Features

Look through the GitHub issues for features. Anything tagged with "feature" is open to whoever wants to implement it.

Write Documentation

pynab could always use more documentation, whether as part of the official pynab docs, in docstrings, or even on the web in blog posts, articles, and such.

Submit Feedback

The best way to send feedback is to file an issue at https://github.com/murodese/pynab/issues.

If you are proposing a feature:

  • Explain in detail how it would work.
  • Keep the scope as narrow as possible, to make it easier to implement.
  • Remember that this is a volunteer-driven project, and that contributions are welcome :)

Get Started!

Ready to contribute? Here's how to set up pynab for local development.

  1. Fork the pynab repo on GitHub.

  2. Clone your fork locally:

    $ git clone [email protected]:your_name_here/pynab.git

  3. Install your local copy into a virtualenv. Assuming you have virtualenvwrapper installed, this is how you set up your fork for local development:

    $ mkvirtualenv pynab
$ cd pynab/
$ python setup.py develop

  4. Create a branch for local development:

    $ git checkout -b name-of-your-bugfix-or-feature
Now you can make your changes locally.

  1. Commit your changes and push your branch to GitHub:

    $ git add .
$ git commit -m "Your detailed description of your changes."
$ git push origin name-of-your-bugfix-or-feature

  2. Submit a pull request through the GitHub website.

Pull Request Guidelines

Before you submit a pull request, check that it meets these guidelines:

  1. If the pull request adds functionality, the docs should be updated. Put your new functionality into a function with a docstring, and add the feature to the list in README.rst.
  1. The pull request should work for Python 3.3.

Looking for something to do?

There are a number of features that'd be nice to have, but I don't have time to write. Have a crack at something on this list if you're bored:

  • Modify scripts/ensure_indexes.py to check for the existence of indexes and create those that are required, but missing. This can't just delete them and re-create - if it did, it could take days to rebuild indexes on large collections.
  • Expand the WebUI - This includes expanding the information available from the API - Work out a way to get SABConnect++ to work with it (no luck so far, since it can't detect XHR events it's unable to inject anything)
  • Expand server management scripts
  • Implement PreDB checking and improve handling bad/uncategorised releases