Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError: 'FakeConnection' object has no attribute 'health_check_interval' #245

Closed
vii opened this issue Aug 2, 2019 · 4 comments
Closed

Comments

@vii
Copy link

vii commented Aug 2, 2019

fakeredis==1.0.3
redis==3.3.4
hiredis==1.0.0

>>> import fakeredis
>>> r = fakeredis.FakeStrictRedis()
>>> r.set('foo', 'bar')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/redis/client.py", line 1519, in set
    return self.execute_command('SET', *pieces)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/redis/client.py", line 838, in execute_command
    conn.send_command(*args)
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/redis/connection.py", line 674, in send_command
    check_health=kwargs.get('check_health', True))
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/redis/connection.py", line 648, in send_packed_command
    self.check_health()
  File "/srv/venvs/service/trusty/service_venv_python3.6/lib/python3.6/site-packages/redis/connection.py", line 629, in check_health
    if self.health_check_interval and time() > self.next_health_check:
AttributeError: 'FakeConnection' object has no attribute 'health_check_interval'
@vii
Copy link
Author

vii commented Aug 2, 2019

this is fine with redis=3.2.1 ...

@Raab70
Copy link
Contributor

Raab70 commented Aug 2, 2019

Duplicate of #240 fixed in #243

@MetcalfeTom
Copy link

Would you mind tagging a new release with this? 🙏We use your awesome package as part of our test suite and this issue is preventing us from upgrading from a vulnerable version of redis

@bmerry
Copy link
Collaborator

bmerry commented Aug 14, 2019

Would you mind tagging a new release with this?

Done (1.0.4).

@bmerry bmerry closed this as completed Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants