Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search required 3 chars to return results, but appear to load with 1 and 2 #323

Open
KronosTheLate opened this issue Nov 26, 2022 · 4 comments
Labels
fixed-in-upcoming-release This ticket is fixed, and will be closed when an upcoming version of Stork is released. improvement-request Request for new or enhanced behavior.

Comments

@KronosTheLate
Copy link

Original issue can be found at MakieOrg/Makie.jl#2004.
Below is a copy of the original issue for convenience.

One and two character searches stay like this:
image

The moment i enter a third char, the result pops up.
It should not appear to load when it fact it is waiting for more input.

@jameslittle230
Copy link
Owner

This is an intentional design decision - I felt like when the UI remained unchanged, it didn't signal to users that they should keep typing to get results.

I'm curious what you expected/hoped to see? Did you expect that the UI remain blank until the user types 3 characters? Or did the word "Filtering" mislead you about what Stork is doing?

@KronosTheLate
Copy link
Author

Fair enough - it is honestly not terrible, and took me all of two seconds to figure out.
I just feel like it would be better to - as you mentioned - show nothing, which 1) does not lie (how I view it, no to be inflamitory), and it does essentially the same. It is just the active word "filtering", along with the three dots that indicate something unfinished, that make me believe that the system is actually filtering something. So yes, nothing would be better.

Optimally, I feel as if the best solution would be to show nothing before 3 chars. However, if the user stops at 1 or 2 chars for say 1 second, prompt the user by showing "Please input 3 character minimum to search".

@jameslittle230
Copy link
Owner

In the version 2.0.0 branch, I'll allow the text displayed to be customizable. I still believe that "Filtering" is the best choice, but I understand that it might not be the best choice for everyone.

@jameslittle230 jameslittle230 added improvement-request Request for new or enhanced behavior. fixed-in-upcoming-release This ticket is fixed, and will be closed when an upcoming version of Stork is released. labels Mar 17, 2023
@KronosTheLate
Copy link
Author

Thanks for making it custumizable ^_^

"Filtering" sound to me like the system is activly doing something, and will produce a result when it is done. Do you not agree that "Filtering" just plain wrong, when in fact the system is waiting for input?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed-in-upcoming-release This ticket is fixed, and will be closed when an upcoming version of Stork is released. improvement-request Request for new or enhanced behavior.
Projects
None yet
Development

No branches or pull requests

2 participants