Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] "compiled" file count in --inspect misses static libraries #279

Open
jameslamb opened this issue Nov 12, 2024 · 0 comments
Open

[bug] "compiled" file count in --inspect misses static libraries #279

jameslamb opened this issue Nov 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jameslamb
Copy link
Owner

What did you expect to happen?

The output of pydistcheck --inspect prints the number of compiled files within a distribution.

print(f" * files: {summary.num_files} ({len(summary.compiled_objects)} compiled)")

That count appears to miss static libraries.

What actually happened?

Static libraries should be counted in the count of compiled files.

How can someone else reproduce this problem?

Consider the following.

docker run --rm -it python:3.12 bash

pip download \
    --no-deps \
    --extra-index-url https://pypi.nvidia.com \
    'librmm-cu12==24.10'

That project has some static library files.

unzip -l ./librmm_cu12*.whl | grep -E '\.a'
#   248882  2024-10-09 14:39   librmm/lib64/libfmt.a
#  1802910  2024-10-09 14:39   librmm/lib64/libspdlog.a

But those are not reported as "compiled" by pydistcheck --inspect.

pip install 'pydistcheck>=0.8.0'
pydistcheck --inspect ./librmm_cu12*.whl

You'll see output that begins like this:

checking './librmm_cu12-24.10.0-py3-none-any.whl'
----- package inspection summary -----
file size
  * compressed size: 3.7M
  * uncompressed size: 15.3M
  * compression space saving: 76.1%
contents
  * directories: 0
  * files: 1770 (0 compiled)

I'd expected that (0 compiled) to actually say (2 compiled).

What version of pydistcheck are you using?

0.8.0

Notes

No response

@jameslamb jameslamb added the bug Something isn't working label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant