Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not work with webpack 4 #11

Closed
francoisromain opened this issue Feb 26, 2018 · 4 comments
Closed

does not work with webpack 4 #11

francoisromain opened this issue Feb 26, 2018 · 4 comments

Comments

@francoisromain
Copy link

francoisromain commented Feb 26, 2018

Hello and thank you for the useful plugin.
Today, Webpack updated to v.4 (with webpack-contrib/html-webpack-plugin) and this plugin now makes an error:

ERROR in   TypeError: callback is not a function

  - index.js:30   [html-webpack-exclude-assets-plugin]/index.js:30:7
  - new Promise
  - Hook.js:35 AsyncSeriesWaterfallHook.lazyCompileHook [as _promise]
    [html-webpack-plugin]/[tapable]/lib/Hook.js:35:21
  - index.js:679 [html-webpack-plugin]/index.js:679:45
  - index.js:170  [html-webpack-plugin]/index.js:170:16
  - util.js:16 tryCatcher  [bluebird]/js/release/util.js:16:23
  - promise.js:512 Promise._settlePromiseFromHandler   [bluebird]/js/release/promise.js:512:31
  - promise.js:569 Promise._settlePromise   [bluebird]/js/release/promise.js:569:18
  - promise.js:614 Promise._settlePromise0   [bluebird]/js/release/promise.js:614:10
  - promise.js:693 Promise._settlePromises   [bluebird]/js/release/promise.js:693:18
  - async.js:133 Async._drainQueue  [bluebird]/js/release/async.js:133:16
  - async.js:143 Async._drainQueues  [bluebird]/js/release/async.js:143:10
  - async.js:17 Immediate.Async.drainQueues   [bluebird]/js/release/async.js:17:14

@jamesjieye
Copy link
Owner

html-webpack-plugin has caused build failure. It hasn't upgraded to support webpack 4.0.

Will work on this once html-webpack-plugin is ready for 4.0.

Thanks!

@francoisromain
Copy link
Author

webpack-contrib/html-webpack-plugin is updated for webpack 4 already, and causing the bug reported above

@jamesjieye
Copy link
Owner

Fixed in version v0.0.6

@francoisromain
Copy link
Author

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants