Skip to content

Commit

Permalink
feat(build): use -facade-group=client in rebuild-schema makefile target
Browse files Browse the repository at this point in the history
The schemas output for python-libjuju should not have contained any
non-client schemas (see this python-libjuju issue
juju/python-libjuju#1099). Switching to only
the client schemas reduces the amount of generated code in
python-libjuju substantially.
  • Loading branch information
james-garner-canonical committed Nov 11, 2024
1 parent 718ceba commit b708772
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -497,9 +497,9 @@ rebuild-schema:
@echo "Generating facade schema..."
# GOOS and GOARCH environment variables are cleared in case the user is trying to cross architecture compilation.
ifdef SCHEMA_PATH
@env GOOS= GOARCH= go run $(COMPILE_FLAGS) $(PROJECT)/generate/schemagen -admin-facades "$(SCHEMA_PATH)"
@env GOOS= GOARCH= go run $(COMPILE_FLAGS) $(PROJECT)/generate/schemagen -admin-facades -facade-group=client "$(SCHEMA_PATH)"
else
@env GOOS= GOARCH= go run $(COMPILE_FLAGS) $(PROJECT)/generate/schemagen -admin-facades \
@env GOOS= GOARCH= go run $(COMPILE_FLAGS) $(PROJECT)/generate/schemagen -admin-facades -facade-group=client \
./apiserver/facades/schema.json
endif

Expand Down

0 comments on commit b708772

Please sign in to comment.