Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support batched inference #19

Closed
jalammar opened this issue Jan 6, 2021 · 1 comment · Fixed by #33
Closed

Support batched inference #19

jalammar opened this issue Jan 6, 2021 · 1 comment · Fixed by #33
Assignees
@jalammar
Labels
enhancement New feature or request

Comments

@jalammar
Copy link
Owner

jalammar commented Jan 6, 2021

Currently, generate() only works with a single input. Ecco should support batched inference.

I am currently working on this in https://github.com/jalammar/ecco/tree/batch-input-activations

This is tied to #18 and __call__ should support batching on its launch. This has an effect on the output.activations tensor, and will bump its dimensions from
(layer, neuron, position)
to become:
(batch, layer, neuron, position)
@jalammar jalammar added the enhancement New feature or request label Jan 6, 2021
@jalammar jalammar self-assigned this Jan 6, 2021
@imjmakki
Copy link

imjmakki commented Jan 8, 2021

Great Job

@jalammar jalammar mentioned this issue Feb 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jalammar jalammar

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Batch input activations jalammar/ecco
2 participants
@jalammar @imjmakki