Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing a timeout in get_blob does not work #53

Open
krishna1m opened this issue Aug 29, 2024 · 2 comments · May be fixed by #54
Open

Passing a timeout in get_blob does not work #53

krishna1m opened this issue Aug 29, 2024 · 2 comments · May be fixed by #54

Comments

@krishna1m
Copy link

Passing a timeout to get_blob passes it in params of the HTTPoison request instead of options(where it is required).
Added an IO.inspect(.) for the HTTPoison request which can also be seen here.

iex(hostname)> {:ok, blob} = Azurex.Blob.get_blob(name, container, recv_timeout: 60_000, timeout: 60_000)
HTTPoison.Request: %HTTPoison.Request{
  method: :get,
  url: "<filename>",
  headers: [],
  body: "",
  params: [recv_timeout: 60000, timeout: 60000],
  options: []
}

What we might want as a possible fix:

iex(hostname)> {:ok, blob} = Azurex.Blob.get_blob(name, container, options: [recv_timeout: 60_000, timeout: 60_000])
HTTPoison.Request: %HTTPoison.Request{
  method: :get,
  url: "<filename>",
  headers: [],
  body: "",
  params: [],
  options: [recv_timeout: 60_000, timeout: 60_000]
}
@krishna1m krishna1m linked a pull request Sep 2, 2024 that will close this issue
Open
@nfishel48
Copy link

Has this been solved yet?

@krishna1m
Copy link
Author

@nfishel48 In the linked PR, it has been solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nfishel48 @krishna1m